Skip to content

fix(ggshield-not-ci): correct logic and print when skipping#4

Merged
iainsproat merged 1 commit intomainfrom
iain/echo-when-skipping
Aug 25, 2022
Merged

fix(ggshield-not-ci): correct logic and print when skipping#4
iainsproat merged 1 commit intomainfrom
iain/echo-when-skipping

Conversation

@iainsproat
Copy link
Copy Markdown
Contributor

Description & motivation

Fix broken hook

Changes:

  • fix: logic in ggshield-not-ci hook
  • feat: log when skipping because CI

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review August 25, 2022 17:00
@iainsproat iainsproat merged commit 20883c9 into main Aug 25, 2022
@iainsproat iainsproat deleted the iain/echo-when-skipping branch August 25, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant