CNX-573 CSIOpening

[bjoernsteinhagen]

Ticket

Please refer here for more information: CNX-573

Description & Motivation

In creating content for Revit & Grasshopper to ETABS, I noticed that the CSIOpening component is essentially useless. We write and append CSIOpening information to the AreaObj, but this information is not used when receiving in ETABS.

Definition in Grasshopper:

Receiving in ETABS:
These AreaObjs should have Yes for attribute Opening

Changes:

Looking at the API docs:

We need to SetOpening in the same way we assign DiaphragmAssignment / CSIAreaSpring:

For AreaToSpeckle we target CSIOpening and not property (otherwise ETABS ➡️ Speckle ➡️ ETABS won't be compatible).

Validation of changes:

Grasshopper ➡️ Speckle ➡️ ETABS

ETABS ➡️ Speckle ➡️ ETABS

Revit ➡️ Speckle ➡️ ETABS

ETABS ➡️ Speckle ➡️ Revit

⚠️ NOTE: this didn't work previously, and is still not working.

Previously:

Now:

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

Comments

This is messy. We need to revisit at a later stage.

[linear]

CNX-573 CSIOpening