fix(revit) #3615: include gutters and other subcategories in Revit connector sending "everything"#3695
Merged
JR-Morgan merged 6 commits intospecklesystems:devfrom Apr 16, 2025
Merged
Conversation
5 tasks
Member
|
Thank you @jcesarpolo, this looks simple enough to review and merge! |
JR-Morgan
approved these changes
Apr 15, 2025
Member
JR-Morgan
left a comment
There was a problem hiding this comment.
Tested in 2022 and 2025. lgtm
Member
|
yep, so this adds extra categories (see diff) to both the This is good, I've checked it works correctly for both filters, and that it doesn't lead to duplicate elements, we simply were not sending categories like wall sweep and gutters from either the I just want to do a final check in Revit 2021, since there may be differences in categories behave in the older versions |
Member
|
2021 looks ok |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
IRevitDocumentCacheExtensions.cs:CacheInitializer()looped only through the categories inAutodesk.Revit.DB.Document.Settings.Categorieswhich returns only the top-level categories, ommiting some supported model categories.CacheInitializer()method to correctly include the mentioned subcategories.Screenshots:
Model exported from Revit sending "everything"

Result on Speckle. No Gutters

Result on Speckle after the fix (Roof Soffits also tested)

Validation of changes:
Checklist: