Skip to content
This repository was archived by the owner on Feb 17, 2026. It is now read-only.

feat: add Playwright test parser support#18

Merged
kubrickcode merged 1 commit intomainfrom
develop/shlee/6
Dec 4, 2025
Merged

feat: add Playwright test parser support#18
kubrickcode merged 1 commit intomainfrom
develop/shlee/6

Conversation

@kubrickcode
Copy link
Member

Add parsing support for Playwright E2E test framework

  • Detect files by @playwright/test import
  • Parse test, test.describe constructs
  • Handle test.skip, test.only, test.fixme status
  • Support test.describe.skip, test.describe.only, test.describe.fixme

fix #6

@gemini-code-assist
Copy link

Summary of Changes

Hello @kubrickcode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a significant feature by integrating parsing support for the Playwright E2E test framework. It enables the system to understand and process Playwright test files, extracting test and suite definitions along with their respective statuses. This enhancement expands the system's compatibility with modern JavaScript/TypeScript testing frameworks, addressing issue #6.

Highlights

  • New Playwright Parser: Introduced a new parsing strategy to support the Playwright E2E test framework, allowing for the detection and parsing of Playwright test files.
  • Test and Suite Parsing: Implemented logic to parse test and test.describe constructs, correctly identifying individual tests and test suites within Playwright files.
  • Status Handling: Added support for various test statuses, including test.skip, test.only, and test.fixme for individual tests, as well as test.describe.skip, test.describe.only, and test.describe.fixme for test suites.
  • File Detection: Files are now detected as Playwright test files if they import @playwright/test and have appropriate file extensions (.ts, .js) or are located in __tests__ directories.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the feature New feature label Dec 4, 2025
@kubrickcode
Copy link
Member Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new parser strategy for the Playwright E2E test framework, which is a great addition. The implementation is well-structured and includes a comprehensive set of tests covering various scenarios, including basic structures, modifiers, and edge cases. My review focuses on a couple of areas in the main implementation file (playwright.go) where the code can be refactored for better clarity, maintainability, and consistency with existing strategies, in line with the repository's style guide on modularity and function design.

@kubrickcode
Copy link
Member Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new parser for the Playwright E2E test framework. The implementation is well-structured and includes a comprehensive set of tests covering various scenarios, including modifiers, nested structures, and edge cases. The code is generally of high quality. I've identified a couple of areas for improvement in playwright.go related to adherence to the repository's style guide, specifically concerning function complexity and the ordering of helper functions. Addressing these points will enhance the code's maintainability and readability.

Add parsing support for Playwright E2E test framework

- Detect files by `@playwright/test` import
- Parse `test`, `test.describe` constructs
- Handle `test.skip`, `test.only`, `test.fixme` status
- Support `test.describe.skip`, `test.describe.only`, `test.describe.fixme`

fix #6
@kubrickcode
Copy link
Member Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new parser for the Playwright test framework. The implementation is clean, well-structured, and correctly follows the existing strategy pattern. It successfully handles various Playwright syntaxes, including test, test.describe, and modifiers like skip, only, and fixme. The accompanying tests are comprehensive, covering basic structures, modifiers, nested suites, and edge cases. My review focuses on a recurring issue in the test files related to parallel subtests, which should be addressed to ensure test correctness.

@kubrickcode kubrickcode merged commit 159350c into main Dec 4, 2025
1 check passed
@kubrickcode kubrickcode deleted the develop/shlee/6 branch December 4, 2025 00:31
@kubrickcode
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

playwright parsing feature

1 participant