This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Support for configurations consisting of multiple files#3
Merged
Conversation
samutamm
approved these changes
Aug 5, 2020
Contributor
There was a problem hiding this comment.
Looks good! I tested with simplified home automation example, similar with the one here https://github.com/speechly/documentation/pull/10 and works nicely with that case. But once tar is uploaded from cli, it cannot (at the moment) be opened from dashboard. Should we warn user about that in docs or somewhere?
Contributor
Author
Good point, we should mention that somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vocabularies are in separate file(s) from the actual rules file. This version will consider a given directory for uploading, and add every
yamlandcsvfile to the uploaded package.Also a small change to
app idpassing is made, so that it is always given as a flag instead of argument. This is mostly to enhance the automatic usage texts printed by the tool.