Batch API: Add support for fetch_data to provide an audio URL #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dumitrugutu @anjz Can you review and hopefully publish a release with this soon? That would help me greatly! Thanks :) |
As per the API, it is possible to pass an audio url via fetch_data instead of an actual audio file. This implements that functionality as per API spec.
Collaborator
|
Hi @TheCrazyLex, thanks for your contribution :) We'll review it shortly. |
anjz
reviewed
Aug 27, 2025
Contributor
anjz
left a comment
anjz
left a comment
There was a problem hiding this comment.
Thanks for your contribution. It looks great. I've just added a few suggestions.
dumitrugutu
reviewed
Aug 27, 2025
Co-authored-by: Anartz Nuin <anartzn@gmail.com> Co-authored-by: Dumitru Gutu <dumitrugutu@users.noreply.github.com>
Co-authored-by: Anartz Nuin <anartzn@gmail.com>
Contributor
Author
|
@dumitrugutu @anjz Implemented your review comments and verified functionality with these changes on my side. |
Collaborator
|
🚀 |
dumitrugutu
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the API, it is possible to pass an audio url via fetch_data instead of an actual audio file.
This implements that functionality as per API spec.
I tested this feature, and it fully works as expected with this code :)