Add Penalty when Smart Turn hasn't been run#86
Merged
sam-s10s merged 2 commits intofix/smart-turnfrom Feb 25, 2026
Merged
Conversation
Contributor
Author
|
Testing I tested this with a quick tyre-kick against a local audio, where I was seeing TTL triggering End Of Turn so quickly that VAD hadn't detected a change in state and triggered Smart Turn yet. Further testing to follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces
SMART_TURN_NO_SIGNALas an annotation we add when Smart Turn is enabled, but we have no result from Smart Turn (neitherSMART_TURN_FALSEnorSMART_TURN_TRUE).This penalty extends the TTL calculation to reduce the likelihood of premature End of Turn.