[615] Bug: fix minor styles for widgets#121
Conversation
📝 WalkthroughWalkthroughThis update introduces new CSS classes for layout and styling adjustments in table and testimonial components, modifies the table widget template to include a section class and link rendering logic, and updates styles for vacancies. No public API changes are made. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TableWidgetTemplate
participant Data
User->>TableWidgetTemplate: Render table widget
TableWidgetTemplate->>Data: Retrieve widget rows
loop For each row in Data
TableWidgetTemplate->>TableWidgetTemplate: Render title and description
alt row.linkTitle exists
TableWidgetTemplate->>TableWidgetTemplate: Determine linkUrl by linkType
TableWidgetTemplate->>User: Render link with attributes
end
end
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
website/modules/asset/ui/src/scss/_testimonials.scss (1)
215-223: Consistent class naming convention
The new.cs_testimonialsclass uses an underscore and diverges from the hyphenated BEM-style naming (e.g.,.sf-testimonials-container). To maintain consistency across the codebase, consider renaming it to.cs-testimonials.website/modules/table-widget/views/widget.html (1)
18-37: Enhance link URL assignment safety
Accessingrow._page[0]orrow._file[0]directly may throw undefined-index errors if those arrays are empty or absent. Guard these checks to prevent runtime issues, for example:{% if row.linkType == 'page' and row._page and row._page | length > 0 %} {% set linkUrl = row._page[0]._url %} {% endif %}This ensures
linkUrlis only set when the source array exists and contains elements.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
website/modules/asset/ui/src/scss/_table-widget.scss(5 hunks)website/modules/asset/ui/src/scss/_testimonials.scss(1 hunks)website/modules/table-widget/views/widget.html(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: e2e-tests
- GitHub Check: unit-tests
- GitHub Check: lint
- GitHub Check: security-scan
🔇 Additional comments (5)
website/modules/table-widget/views/widget.html (1)
1-1: Section element styling class alignment
Includingsf-table-sectionin the<section>now activates the new flex-column layout defined in_table-widget.scss, correctly applying the updated styles.website/modules/asset/ui/src/scss/_table-widget.scss (4)
1-4: New section flex container
The.sf-table-sectionwrapper adoptingdisplay: flex; flex-direction: column;correctly scopes the section to use the updated layout. Implementation is sound.
9-11: Centering intro content
Addingalign-self: center; width: 100%;to.sf-table-introensures it respects the parent container’s max-width and remains centered. This aligns with the intended design.
25-26: Horizontal centering of table rows
The newjustify-content: center;on.sf-tablecenters rows in multi-column layouts at medium breakpoints, improving visual balance.
108-109: Consistent spacing for table links
The margin-top updates (24px/32pxat medium breakpoints) for.sf-table-linkalign with other components and enhance readability. Looks good.
🔍 Vulnerabilities of
|
| digest | sha256:2304be5636ec52eebeec62147f3548314c64fea0329b47c1c808b39ad31a911f |
| vulnerabilities |     |
| platform | linux/amd64 |
| size | 284 MB |
| packages | 935 |
📦 Base Image node:23-alpine
| also known as |
|
| digest | sha256:169ee1b69bd3f5c7c8508a9919e8b367bba9dc7fa9a03097ec9f85d2e8179631 |
| vulnerabilities |  |
Description
| ||||||||||||
Description
| ||||||||||||
Description
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
website/modules/asset/ui/src/scss/_vacancies.scss (1)
82-92: DRY up duplicate.vacancy-cardblocks
The new sibling selector styles for.vacancy-card + .sf-vacancies_footer h2 { … }are declared in a separate
.vacancy-cardblock. For maintainability, merge this nested rule into the existing.vacancy-cardblock (around lines 13–32) so all.vacancy-cardstyles live in one place.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/modules/asset/ui/src/scss/_vacancies.scss(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: e2e-tests
- GitHub Check: lint
- GitHub Check: unit-tests
- GitHub Check: security-scan
🔇 Additional comments (1)
website/modules/asset/ui/src/scss/_vacancies.scss (1)
101-101: Approve the margin reset for footer headings
Resetting the defaultmargin-topon.sf-vacancies_footer h2(to0 0 8pxand0 0 32pxat medium breakpoint) correctly delegates the top spacing to the sibling rule. This matches the intended responsive design.Also applies to: 104-104
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/modules/asset/ui/src/scss/_vacancies.scss(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: sonarqube
- GitHub Check: e2e-tests
- GitHub Check: security-scan
|
4 participants
This PR includes several style improvements for widgets: