Skip to content

[528] Create responsive styles of summary Case Studies page#137

Merged
Anton-88 merged 9 commits into
mainfrom
528-create-responsive-styles-of-summary-case-studies-page
Jun 5, 2025
Merged

[528] Create responsive styles of summary Case Studies page#137
Anton-88 merged 9 commits into
mainfrom
528-create-responsive-styles-of-summary-case-studies-page

Conversation

@yuramax
Copy link
Copy Markdown
Contributor

@yuramax yuramax commented May 30, 2025

  • initial styles and functionality for independent Filters and Case Studies cards scrolling

@yuramax yuramax self-assigned this May 30, 2025
@yuramax yuramax requested a review from killev as a code owner May 30, 2025 09:33
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2025

📝 Walkthrough

Walkthrough

This change updates the styling and template logic for the filter info section on the case studies page. It introduces sticky positioning and visual adjustments to the .cs_filter-info container in SCSS, and modifies the HTML template to ensure the filter info block only renders when active filters are present.

Changes

File(s) Change Summary
website/modules/asset/ui/src/scss/_cases.scss Adjusted .cs_list and .cs_filter-info styles: removed top border/padding, added sticky position, background, border, and responsive offsets.
website/modules/case-studies-page/views/index.html Moved the conditional logic for rendering .cs_filter-info inside the container, so it only renders if filters are active.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Browser
  participant TemplateEngine

  User->>Browser: Loads case studies page
  Browser->>TemplateEngine: Render index.html
  TemplateEngine->>TemplateEngine: Check for active filters
  alt hasActiveFilters
    TemplateEngine->>Browser: Render .cs_filter-info block (with sticky styling)
  else no active filters
    TemplateEngine->>Browser: Do not render .cs_filter-info block
  end
  Browser->>User: Displays page with updated filter info behavior
Loading

Possibly related PRs

Suggested reviewers

  • Anton-88
  • VitalyyP
  • IhorMasechko
  • killev

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9edae0c and 9ae935c.

📒 Files selected for processing (2)
  • website/modules/asset/ui/src/scss/_cases.scss (1 hunks)
  • website/modules/case-studies-page/views/index.html (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • website/modules/case-studies-page/views/index.html
🚧 Files skipped from review as they are similar to previous changes (1)
  • website/modules/asset/ui/src/scss/_cases.scss
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: lint
  • GitHub Check: e2e-tests
  • GitHub Check: unit-tests
  • GitHub Check: security-scan
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 30, 2025

🔍 Vulnerabilities of apostrophe-cms:test

📦 Image Reference apostrophe-cms:test
digestsha256:188c2191c988ac5809e6197cc7c0412b5af438969e5cd673df122436acc47cec
vulnerabilitiescritical: 0 high: 5 medium: 0 low: 0
platformlinux/amd64
size289 MB
packages971
📦 Base Image node:23-alpine
also known as
  • 23-alpine3.22
  • 23.11-alpine
  • 23.11-alpine3.22
  • 23.11.1-alpine
  • 23.11.1-alpine3.22
digestsha256:b9d38d589853406ff0d4364f21969840c3e0397087643aef8eede40edbb6c7cd
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
critical: 0 high: 1 medium: 0 low: 0 connect-multiparty 2.2.0 (npm)

pkg:npm/connect-multiparty@2.2.0

high 7.8: CVE--2022--29623 Unrestricted Upload of File with Dangerous Type

Affected range<=2.2.0
Fixed versionNot Fixed
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score0.334%
EPSS Percentile56th percentile
Description

An arbitrary file upload vulnerability in the file upload module of Express Connect-Multiparty 2.2.0 allows attackers to execute arbitrary code via a crafted PDF file. NOTE: the Supplier has not verified this vulnerability report.

critical: 0 high: 1 medium: 0 low: 0 tar-fs 3.0.8 (npm)

pkg:npm/tar-fs@3.0.8

high 8.7: CVE--2025--48387 Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')

Affected range>=3.0.0
<3.0.9
Fixed version3.0.9
CVSS Score8.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N
EPSS Score0.063%
EPSS Percentile20th percentile
Description

Impact

v3.0.8, v2.1.2, v1.16.4 and below

Patches

Has been patched in 3.0.9, 2.1.3, and 1.16.5

Workarounds

You can use the ignore option to ignore non files/directories.

  ignore (_, header) {
    // pass files & directories, ignore e.g. symlinks
    return header.type !== 'file' && header.type !== 'directory'
  }

Credit

Thank you Caleb Brown from Google Open Source Security Team for reporting this in detail.

critical: 0 high: 1 medium: 0 low: 0 async 1.5.2 (npm)

pkg:npm/async@1.5.2

high 7.8: CVE--2021--43138 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range<2.6.4
Fixed version2.6.4, 3.2.2
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score1.061%
EPSS Percentile77th percentile
Description

A vulnerability exists in Async through 3.2.1 (fixed in 3.2.2), which could let a malicious user obtain privileges via the mapValues() method.

critical: 0 high: 1 medium: 0 low: 0 tar-fs 2.1.2 (npm)

pkg:npm/tar-fs@2.1.2

high 8.7: CVE--2025--48387 Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')

Affected range>=2.0.0
<2.1.3
Fixed version2.1.3
CVSS Score8.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N
EPSS Score0.063%
EPSS Percentile20th percentile
Description

Impact

v3.0.8, v2.1.2, v1.16.4 and below

Patches

Has been patched in 3.0.9, 2.1.3, and 1.16.5

Workarounds

You can use the ignore option to ignore non files/directories.

  ignore (_, header) {
    // pass files & directories, ignore e.g. symlinks
    return header.type !== 'file' && header.type !== 'directory'
  }

Credit

Thank you Caleb Brown from Google Open Source Security Team for reporting this in detail.

critical: 0 high: 1 medium: 0 low: 0 async 0.9.2 (npm)

pkg:npm/async@0.9.2

high 7.8: CVE--2021--43138 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range<2.6.4
Fixed version2.6.4, 3.2.2
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score1.061%
EPSS Percentile77th percentile
Description

A vulnerability exists in Async through 3.2.1 (fixed in 3.2.2), which could let a malicious user obtain privileges via the mapValues() method.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa16f2f and 9edae0c.

📒 Files selected for processing (2)
  • website/modules/asset/ui/src/index.js (1 hunks)
  • website/modules/asset/ui/src/scss/_cases.scss (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
website/modules/asset/ui/src/index.js (2)
website/modules/asset/ui/src/swipers.js (1)
  • initAllSwipers (57-69)
website/modules/asset/ui/src/smoothCounters.js (1)
  • initSmoothCounters (58-78)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint
  • GitHub Check: e2e-tests
  • GitHub Check: security-scan
🔇 Additional comments (4)
website/modules/asset/ui/src/scss/_cases.scss (2)

74-85: LGTM! Solid foundation for sticky positioning.

The positioning, z-index, and transition properties provide a good foundation for the sticky behavior. The .is-fixed modifier class properly implements fixed positioning across the full viewport width.


94-114: Well-implemented scrollable grid with custom scrollbars.

The implementation correctly handles:

  • Flexible layout with flex: 1
  • Smooth height transitions for dynamic resizing
  • Custom webkit scrollbar styling for better UX
  • Appropriate padding for scrollbar spacing
website/modules/asset/ui/src/index.js (2)

62-68: Good defensive programming with early returns.

The function properly validates essential DOM elements before proceeding and uses early returns to avoid unnecessary processing.


70-77: Smart use of placeholder for layout maintenance.

Creating a placeholder element to maintain layout flow when the list becomes fixed is a good approach. Getting the initial position correctly accounts for existing scroll position.

Comment thread website/modules/asset/ui/src/scss/_cases.scss Outdated
Comment thread website/modules/asset/ui/src/index.js Outdated
Comment thread website/modules/asset/ui/src/index.js Outdated
Comment thread website/modules/asset/ui/src/index.js Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

@VitalyyP VitalyyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@IhorMasechko IhorMasechko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@killev killev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Anton-88 Anton-88 merged commit f2f9660 into main Jun 5, 2025
12 checks passed
@Anton-88 Anton-88 deleted the 528-create-responsive-styles-of-summary-case-studies-page branch June 5, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants