Skip to content

[469] Added categories and connected them to tags#63

Merged
killev merged 10 commits into
mainfrom
469-create-category-and-connect-tags-to-them
May 12, 2025
Merged

[469] Added categories and connected them to tags#63
killev merged 10 commits into
mainfrom
469-create-category-and-connect-tags-to-them

Conversation

@Anton-88
Copy link
Copy Markdown
Contributor

@Anton-88 Anton-88 commented May 6, 2025

Added categories and connected them to tags

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2025

"""

Walkthrough

A new "categories" module is introduced as a piece type, enabling management of categories with title and description fields. The admin bar now includes a "Categories" group. The "cases-tags" piece type is updated to require a relationship to a category, both in its schema and listing columns.

Changes

File(s) Change Summary
website/app.js Added 'categories' to the modules configuration in createAposConfig.
website/modules/@apostrophecms/admin-bar/index.js Added a "Categories" group with the 'categories' item to the admin bar configuration.
website/modules/categories/index.js Introduced a new piece type module for "Category" with title and description fields and grouped field configuration.
website/modules/cases-tags/index.js Added a required _category relationship field to "cases-tags", updated field groups, and added a listing column.

Sequence Diagram(s)

sequenceDiagram
    participant Admin as Admin User
    participant AdminBar as Admin Bar
    participant Categories as Categories Module
    participant CasesTags as Cases-Tags Module

    Admin->>AdminBar: View admin bar
    AdminBar-->>Admin: Show "Categories" group

    Admin->>Categories: Create/Edit Category (title, description)
    Categories-->>Admin: Save/Display category

    Admin->>CasesTags: Create/Edit Tag
    CasesTags->>Categories: Select related Category (required)
    CasesTags-->>Admin: Save/Display tag with category
Loading

Suggested reviewers

  • IhorMasechko
  • VitalyyP
    """

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d6bed6 and 8ce6f39.

📒 Files selected for processing (2)
  • website/app.js (1 hunks)
  • website/modules/cases-tags/index.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • website/app.js
  • website/modules/cases-tags/index.js
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: unit-tests
  • GitHub Check: e2e-tests
  • GitHub Check: security-scan
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2025

🔍 Vulnerabilities of apostrophe-cms:test

📦 Image Reference apostrophe-cms:test
digestsha256:58aa8eaa07e7343574427dbb91230a2f2f0f9bdaa8d569e2118132d9622f2bc4
vulnerabilitiescritical: 0 high: 2 medium: 0 low: 0
platformlinux/amd64
size284 MB
packages934
📦 Base Image node:23-alpine
also known as
  • 23-alpine3.21
  • 23.11-alpine
  • 23.11-alpine3.21
  • 23.11.0-alpine
  • 23.11.0-alpine3.21
  • alpine
  • alpine3.21
  • current-alpine
  • current-alpine3.21
digestsha256:0d468be7d2997dd2f6a3cda45e121a6b5140eb7ba3eba299a215030dbb0fb1ca
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
critical: 0 high: 1 medium: 0 low: 0 async 1.5.2 (npm)

pkg:npm/async@1.5.2

high 7.8: CVE--2021--43138 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range<2.6.4
Fixed version2.6.4, 3.2.2
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score1.061%
EPSS Percentile76th percentile
Description

A vulnerability exists in Async through 3.2.1 (fixed in 3.2.2), which could let a malicious user obtain privileges via the mapValues() method.

critical: 0 high: 1 medium: 0 low: 0 async 0.9.2 (npm)

pkg:npm/async@0.9.2

high 7.8: CVE--2021--43138 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range<2.6.4
Fixed version2.6.4, 3.2.2
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score1.061%
EPSS Percentile76th percentile
Description

A vulnerability exists in Async through 3.2.1 (fixed in 3.2.2), which could let a malicious user obtain privileges via the mapValues() method.

@Anton-88 Anton-88 self-assigned this May 6, 2025
VitalyyP
VitalyyP previously approved these changes May 6, 2025
Copy link
Copy Markdown
Contributor

@VitalyyP VitalyyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yuramax
yuramax previously approved these changes May 6, 2025
Copy link
Copy Markdown
Contributor

@yuramax yuramax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anton-88 Anton-88 requested a review from killev May 6, 2025 22:05
IhorMasechko
IhorMasechko previously approved these changes May 7, 2025
Copy link
Copy Markdown
Contributor

@IhorMasechko IhorMasechko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@yuramax yuramax changed the title Added categories and connected them to tags [469] Added categories and connected them to tags May 9, 2025
Copy link
Copy Markdown
Collaborator

@killev killev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approved

@Anton-88 Anton-88 dismissed stale reviews from VitalyyP, IhorMasechko, and yuramax via 8ce6f39 May 12, 2025 20:00
Copy link
Copy Markdown
Collaborator

@killev killev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killev killev enabled auto-merge (squash) May 12, 2025 20:21
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@yuramax yuramax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@killev killev merged commit e40add2 into main May 12, 2025
12 checks passed
@killev killev deleted the 469-create-category-and-connect-tags-to-them branch May 12, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants