Fix qBittorrent authentication with 204 No Content response#34
Merged
Conversation
Add ability to flip graph orientation
feat: add dynamic build-time versioning with About section in Settings
Graph fixes and Windows Docker instructions
API for HA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes qBittorrent authentication against newer qBittorrent WebAPI versions that return
204 No Contentfor a successful login response.Speedarr previously only treated
200 OKwith bodyOk.as a successful qBittorrent login. With newer qBittorrent versions, authentication can succeed while returning204, causing Speedarr to incorrectly fail with: