Fix Issue #1464: Rails 7.1 Zeitwerk autoloading race condition

[takaokouji]

Summary

Fixes JSONAPI-Resources#1464 by removing the ActiveSupport.on_load lazy loading mechanism that causes race conditions with Zeitwerk in Rails 7.1+.

Problem

In Rails 7.1 with Zeitwerk autoloading and eager_load disabled, tests would intermittently fail with:

NameError: uninitialized constant JSONAPI::ResourceController

The error was random (2-3 to 20-30 times per test run) and only occurred locally, not in CI where eager loading is enabled.

Root Cause

The gem used ActiveSupport.on_load(:action_controller_base) to delay loading of ResourceController:

if Rails::VERSION::MAJOR >= 6
  ActiveSupport.on_load(:action_controller_base) do
    require 'jsonapi/resource_controller'
  end
else
  require 'jsonapi/resource_controller'
end

This lazy loading mechanism creates a race condition with Zeitwerk's autoloading in Rails 7.1+.

Solution

Remove the conditional lazy loading and always require ResourceController directly:

require 'jsonapi/resource_controller'

This eliminates the race condition and ensures ResourceController is always available.

Testing

• All 691 tests pass
• No changes to test behavior
• Compatible with Rails 6.1+

Workarounds No Longer Needed

• config.eager_load = true in test environment
• Manual require 'jsonapi/resource_controller' before use
• Switching to ActsAsResourceController mixin

Related

• Upstream issue: https://github.com/cerebris/jsonapi-resources/issues/1464
• Similar issues in other gems: rails_admin, exception_notification

🤖 Generated with Claude Code