Fix ActionController::ForceSSL compatibility with Rails 8.0+ (Issue #1477)#23
Merged
takaokouji merged 1 commit intomasterfrom Jan 21, 2026
Merged
Conversation
Issue JSONAPI-Resources#1477 reported: - ActionController::ForceSSL was removed in Rails 8.0 - Previous code caused 'uninitialized constant' error Changes: - Check if ActionController::ForceSSL is defined before using it - Added FORCE_SSL_MODULE constant with proper version checking - Only include ForceSSL for Rails < 6.1 where it exists Note: - ForceSSL existed in Rails < 6.1 and was removed in Rails 8.0 - force_ssl functionality is now integrated into ActionController::Base - This fix prevents NameError on Rails 8.0+ Tested on: - Rails 8.0.4: All tests pass, no ForceSSL errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ActionController::ForceSSL compatibility issue with Rails 8.0+, addressing part of Issue JSONAPI-Resources#1477.
Issue JSONAPI-Resources#1477
uninitialized constanterrorsThis PR addresses Problem 1.
Changes
FORCE_SSL_MODULEconstant with proper version and existence checkingdefined?()check to prevent NameError in Rails 8.0+Code Changes
Background
force_sslfunctionality is now integrated directly into ActionController::BaseTest Results
Tested on Rails 8.0.4:
Related
Note on Problem 2
The validation status code issue (Problem 2) was not reproducible in our tests. All validation tests correctly return 422 status code on Rails 8.0.4. This may have been fixed in other changes or may require specific reproduction steps.