Fix Working Directory and JRE Fields in Plugin UI#577
Merged
raniejade merged 3 commits intospekframework:2.xfrom Jan 29, 2019
floralvikings:2.x
Merged
Fix Working Directory and JRE Fields in Plugin UI#577raniejade merged 3 commits intospekframework:2.xfrom floralvikings:2.x
raniejade merged 3 commits intospekframework:2.xfrom
floralvikings:2.x
Conversation
Member
|
@floralvikings thanks! Can you apply the same changes to the android plugin? https://github.com/spekframework/spek/blob/2.x/spek-ide-plugin/android-studio/src/main/kotlin/org/spekframework/intellij/SpekAndroidSettingsEditor.kt |
Contributor
Author
|
Sure; I'll get it done this evening 👍 |
Contributor
Author
|
@raniejade added changes to the android plugin 😄 |
Member
|
Sweet, thanks again @floralvikings! Taking a look tonight! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
data.workingDirectoryfield was set to itself instead of the intended value, meaning it was wiped every time the run configuration was modified; now it is set correctly.Similar story with the
alternativeJrePathproperties. Found these while researching #563.