Skip to content

[AI] Expand Test Coverage - eldritch-core/lexer#1707

Merged
KCarretto merged 1 commit intomainfrom
expand-test-coverage-eldritch-lexer-9256918218683965876
Feb 2, 2026
Merged

[AI] Expand Test Coverage - eldritch-core/lexer#1707
KCarretto merged 1 commit intomainfrom
expand-test-coverage-eldritch-lexer-9256918218683965876

Conversation

@KCarretto
Copy link
Collaborator

Expanded test coverage for the Eldritch Core Lexer in implants/lib/eldritch/eldritch-core.

This PR:

  • Refactors tests/lexer_edges.rs to include a comprehensive set of test cases.
  • Validates numeric parsing, including edge cases like 00 and current behavior for 0x literals.
  • Adds extensive tests for string literals, including empty strings, escapes, and f-strings.
  • Verifies correct tokenization of all operators, keywords, and delimiters.
  • Checks whitespace and indentation handling.
  • Confirms stability of the lexer implementation.

PR created automatically by Jules for task 9256918218683965876 started by @KCarretto

Significantly expanded the test suite in `implants/lib/eldritch/eldritch-core/tests/lexer_edges.rs` to cover a wider range of edge cases and functionalities.

Changes include:
- Added tests for numeric variants (float formats, edge cases like `00`).
- Documented current behavior for unsupported hex literals (`0x123` -> `0`, `x123`).
- Added comprehensive string literal tests (empty, spaces, mixed quotes, escape sequences, triple quotes).
- Added tests for f-string parsing (simple and complex interpolation).
- Expanded operator tests to include compound assignments and bitwise operators.
- Added tests for keywords, delimiters, and comments.
- Verified whitespace handling and indentation logic.
- Ensured flake stability by running tests 20x.

This improves the robustness of the Eldritch DSL core component by explicitly testing boundary conditions and documenting existing behaviors.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2514    ±0 2514    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#759 2514 2514 0 0 0 0 17.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2514 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review February 2, 2026 19:13
@KCarretto KCarretto requested a review from hulto February 2, 2026 19:14
@KCarretto KCarretto enabled auto-merge February 2, 2026 22:00
@KCarretto KCarretto added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit 1f6020d Feb 2, 2026
8 checks passed
@KCarretto KCarretto deleted the expand-test-coverage-eldritch-lexer-9256918218683965876 branch February 2, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants