Skip to content

[AI] Expand Test Coverage - eldritch-core/lexer#1730

Merged
KCarretto merged 1 commit intomainfrom
eldritch-core-lexer-tests-3234571322975722423
Feb 6, 2026
Merged

[AI] Expand Test Coverage - eldritch-core/lexer#1730
KCarretto merged 1 commit intomainfrom
eldritch-core-lexer-tests-3234571322975722423

Conversation

@KCarretto
Copy link
Collaborator

Added new integration tests for eldritch-core Lexer covering edge cases like inconsistent indentation, unterminated strings, f-string errors, and raw string escapes.


PR created automatically by Jules for task 3234571322975722423 started by @KCarretto

Added 5 new test cases in `implants/lib/eldritch/eldritch-core/tests/lexer_more_edges.rs` to cover edge cases in the Eldritch DSL Lexer:
- Inconsistent indentation errors
- Unterminated string literals with trailing escapes
- Unmatched braces in f-string expressions (using triple quotes to expose inner errors)
- Raw string escape handling
- Bitwise NOT operator tokenization

Verified stability by running tests 20 times.
Ran `cargo fmt` in `implants/`.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2559    ±0 2559    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#824 2559 2559 0 0 0 0 16.7s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2559 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto requested a review from hulto February 6, 2026 00:33
@KCarretto KCarretto marked this pull request as ready for review February 6, 2026 00:33
@KCarretto KCarretto enabled auto-merge February 6, 2026 00:33
@KCarretto KCarretto added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 14a35af Feb 6, 2026
8 checks passed
@KCarretto KCarretto deleted the eldritch-core-lexer-tests-3234571322975722423 branch February 6, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants