Update tonic to v0.14.3 and migrate to tonic-prost-build#1775
Merged
Conversation
This commit updates the tonic gRPC framework to the latest version (0.14.3) and migrates the build system to use tonic-prost-build, which is required for the new API. ## Key Changes ### Dependency Updates - Migrated from `tonic-build` to `tonic-prost-build` v0.14.3 - Updated hyper proxy support: - gRPC transport: hyper-http-proxy 1.1.0 (hyper 1.x compatible) - HTTP/1.1 transport: hyper-proxy 0.9.1 as hyper-proxy-legacy (hyper 0.14) - Added supporting dependencies: http, tower, hyper-util, http-body-util ### API Migrations - **build.rs**: Replaced `tonic_build::configure()` with `tonic_prost_build::configure()` and `.compile()` with `.compile_protos()` - **grpc.rs**: Updated to use hyper-http-proxy for hyper 1.x compatibility - **http.rs**: Migrated to hyper_legacy namespace to maintain hyper 0.14 for HTTP/1.1 - **dns_resolver.rs**: Updated DNS-over-HTTPS resolver to use hyper_legacy types ### Code Quality - Fixed unused import warnings - Fixed unnecessary mut warning in dns.rs - Regenerated all proto files with new tonic-prost-build ## Testing - 78/79 tests passing - 1 pre-existing test failure in pb::config unrelated to tonic upgrade - Workspace compiles cleanly with cargo check ## Notes - HTTP/1.1 transport continues using hyper 0.14 for stability - gRPC transport now uses hyper 1.x via tonic 0.14.3 - DOH support temporarily disabled for gRPC pending hyper 1.x DNS resolver Generated with [Claude Code](https://claude.com/claude-code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
* Re-add DoH support to the grpc.rs transport - Implement `HickoryResolverServiceHyper1` in `dns_resolver.rs` to support `tower::Service` as required by `hyper-util` 0.1. - Integrate the new DoH resolver into `grpc.rs`. - Add unit tests for the new Hyper 1.x DoH components. - Ensure compatibility with existing `hyper_legacy` (hyper 0.14) based transports. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com> * Re-add DoH support to the grpc.rs transport and fix HTTPS support - Implement `HickoryResolverServiceHyper1` in `dns_resolver.rs` to support `tower::Service` as required by `hyper-util` 0.1. - Integrate the new DoH resolver into `grpc.rs`. - Fix HTTPS support in gRPC transport by wrapping the connector in `hyper-rustls` `HttpsConnector`, which is necessary when using custom connectors with `tonic` 0.14 and HTTPS URIs. - Explicitly configure `rustls` with the `ring` crypto provider to avoid ambiguity and ensure compatibility with other crates in the workspace. - Update `Cargo.toml` with `hyper-rustls` and `rustls` dependencies. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com> * Re-add DoH support to the grpc.rs transport and fix HTTPS support - Implement `HickoryResolverServiceHyper1` in `dns_resolver.rs` to support `tower::Service` as required by `hyper-util` 0.1 (Hyper 1.x). - Integrate the new DoH resolver into `grpc.rs`. - Implement `ForceHttpsConnector` workaround in `grpc.rs` to bypass `tonic` 0.14's strict scheme check for `https://` URIs when using custom connectors. - Explicitly configure `rustls` with the `ring` crypto provider to ensure a default provider is available. - Update `Cargo.toml` with `hyper-rustls`, `rustls`, and necessary features. - Restore unit tests for DoH and add verification for Hyper 1.x components. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com> --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
hulto
commented
Feb 9, 2026
implants/lib/transport/Cargo.toml
Outdated
| tokio = { workspace = true, features = ["macros", "rt-multi-thread"] } | ||
| tokio-stream = { workspace = true } | ||
| tonic = { workspace = true, features = ["tls-webpki-roots"] } | ||
| rustls = { version = "0.23", features = ["ring"] } |
Collaborator
Author
There was a problem hiding this comment.
move these to workspace
* Disable cert checking * fix http1 callback URI * Refactor ignore certs
KCarretto
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the tonic gRPC framework to the latest version (0.14.3) and migrates the build system to use tonic-prost-build, which is required for the new API.
Key Changes
Dependency Updates
tonic-buildtotonic-prost-buildv0.14.3API Migrations
tonic_build::configure()withtonic_prost_build::configure()and.compile()with.compile_protos()Code Quality
Testing
Notes
Generated with Claude Code via Happy
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #