Skip to content

Prefix Shell V2 Output with Truncated Input#1841

Merged
KCarretto merged 1 commit intomainfrom
shellv2-input-prefix-5341438117760528229
Feb 22, 2026
Merged

Prefix Shell V2 Output with Truncated Input#1841
KCarretto merged 1 commit intomainfrom
shellv2-input-prefix-5341438117760528229

Conversation

@KCarretto
Copy link
Collaborator

This change updates the tavern backend shell handler to include the input command as a prefix in the websocket output messages sent to the frontend. This provides context in the Shell V2 terminal, allowing users to associate output with specific commands. The input is truncated to 64 characters to maintain readability. The implementation handles both interactive (real-time streaming via portals) and non-interactive (polled from database) modes, ensuring consistent behavior. Existing integration tests were updated, and a new test case for truncation was added.


PR created automatically by Jules for task 5341438117760528229 started by @KCarretto

Updates the Shell V2 output handling in `tavern/internal/http/shell/handler.go` to prefix the output and error messages with the input command that caused them.

- Prefixes standard output with `[+] <truncated_input>\n`.
- Prefixes error output with `[!] <truncated_input>\n`.
- Truncates input strings to 64 characters to avoid cluttering the terminal.
- Updates integration tests in `tavern/internal/http/shell/integration_test.go` to verify the new prefix format and truncation logic.
- Adds `TestTruncation` to explicitly test the input truncation behavior.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2608    ±0 2608    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1032 2608 2608 0 0 0 0 36.4s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2608 0 0 5.1s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestDockerExecutor_Build_ContextCancellation 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
TestDockerExecutor_Build_SimpleEcho 1 3.1s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review February 21, 2026 23:43
@KCarretto KCarretto requested a review from hulto February 21, 2026 23:43
@KCarretto KCarretto added this pull request to the merge queue Feb 21, 2026
Merged via the queue into main with commit 0024292 Feb 22, 2026
8 checks passed
@KCarretto KCarretto deleted the shellv2-input-prefix-5341438117760528229 branch February 22, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants