Merged
Conversation
Added support for configuring jitter in the imix agent callback. The jitter value represents the maximum percentage of the callback interval to subtract from the sleep duration, effectively randomizing the callback timing. Changes: - Updated `tavern/internal/c2/proto/c2.proto` to include `jitter` field in `Transport`. - Manually updated `implants/lib/pb/src/generated/c2.rs` to include `jitter` in `Transport` struct. - Updated `implants/lib/pb/src/config.rs` to parse `jitter` from DSN. - Updated `implants/lib/pb/build.rs` to support `jitter` in YAML config. - Updated `implants/imix/src/agent.rs` to expose `get_callback_jitter`. - Updated `implants/imix/src/run.rs` to use jitter when calculating sleep duration. - Added `rand` dependency to `implants/imix/Cargo.toml`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Fixed `error[E0063]: missing field jitter in initializer of pb::c2::Transport` which occurred in `implants/lib/transport` due to the recent addition of the `jitter` field to the `Transport` protobuf message. Changes: - Updated `implants/lib/transport/src/dns.rs` to initialize `jitter: 0.0` in `Transport` struct. - Updated `implants/lib/transport/src/lib.rs` to initialize `jitter: 0.0` in `Transport` struct. - Verified compilation with `cargo check -p transport` and tests with `cargo test -p transport`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Fixed `error[E0063]: missing field jitter in initializer of pb::c2::Transport` in `imix/src/tests/agent_trait_tests.rs`. This was a lingering issue similar to the previous fix in the `transport` library. Changes: - Updated `implants/imix/src/tests/agent_trait_tests.rs` to initialize `jitter: 0.0` in `pb::c2::Transport` struct initializations. - Verified compilation and tests with `cargo check -p imix --tests` and `cargo test -p imix`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented jitter for
imixagent callback.Added
jitterfield toTransportprotobuf message and Rust struct.Implemented configuration parsing for
jitterfrom DSN and YAML.Implemented randomized sleep duration calculation in
imixagent loop using the configured jitter.PR created automatically by Jules for task 16886886867242433849 started by @KCarretto