Skip to content

Refactor ShellV2 frontend page#1881

Merged
KCarretto merged 1 commit intomainfrom
refactor-shellv2-8640530444428884757
Feb 24, 2026
Merged

Refactor ShellV2 frontend page#1881
KCarretto merged 1 commit intomainfrom
refactor-shellv2-8640530444428884757

Conversation

@KCarretto
Copy link
Collaborator

Refactored tavern/internal/www/src/pages/shellv2/index.tsx to improve maintainability by separating concerns into distinct components and hooks.

  • Created components/ directory for UI parts.
  • Created hooks/ directory for state and logic.
  • Created graphql.ts for queries.
  • Updated index.tsx to be a clean wrapper.
  • Verified functionality by building the frontend and checking component rendering in a headless environment.

PR created automatically by Jules for task 8640530444428884757 started by @KCarretto

Splits the monolithic `ShellV2` component into smaller, manageable components:
- `ShellHeader`: Displays breadcrumbs and title.
- `ShellStatusBar`: Displays portal status and callback timer.
- `ShellTerminal`: Wraps xterm.js terminal and completions.
- `ShellCompletions`: Renders the autocomplete dropdown.

Extracts logic into custom hooks:
- `useShellData`: Manages GraphQL queries for shell, beacon, and portal data.
- `useCallbackTimer`: Calculates time until next callback.
- `useShellTerminal`: Encapsulates terminal initialization, WebSocket handling, and input state.

Updates `index.tsx` to compose these components.
Includes updated build artifacts as required by the repo structure.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2658    ±0 2658    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1172 2658 2658 0 0 0 0 37.2s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2658 0 0 5.5s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.7s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.7s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.7s 4.6s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto marked this pull request as ready for review February 24, 2026 04:59
@KCarretto KCarretto added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 2875dc9 Feb 24, 2026
13 of 14 checks passed
@KCarretto KCarretto deleted the refactor-shellv2-8640530444428884757 branch February 24, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants