Conversation
Splits the monolithic `ShellV2` component into smaller, manageable components: - `ShellHeader`: Displays breadcrumbs and title. - `ShellStatusBar`: Displays portal status and callback timer. - `ShellTerminal`: Wraps xterm.js terminal and completions. - `ShellCompletions`: Renders the autocomplete dropdown. Extracts logic into custom hooks: - `useShellData`: Manages GraphQL queries for shell, beacon, and portal data. - `useCallbackTimer`: Calculates time until next callback. - `useShellTerminal`: Encapsulates terminal initialization, WebSocket handling, and input state. Updates `index.tsx` to compose these components. Includes updated build artifacts as required by the repo structure. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Refactored
tavern/internal/www/src/pages/shellv2/index.tsxto improve maintainability by separating concerns into distinct components and hooks.components/directory for UI parts.hooks/directory for state and logic.graphql.tsfor queries.index.tsxto be a clean wrapper.PR created automatically by Jules for task 8640530444428884757 started by @KCarretto