ShellV2 UI Improvements and Timer Refinement#1895
Conversation
- Update ShellV2 header to include a red BETA badge and a bug report link.
- Update ShellV2 title to display "{beacon} @ {host}" with a link to the host details page.
- Update `GET_SHELL` GraphQL query to fetch host details.
- Refactor `useCallbackTimer` to use `moment.duration` for precise time formatting (e.g., "1 min 20s") and lenient latency handling.
- Verify changes with a Playwright script.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
- Update ShellV2 header to include a red BETA badge and a bug report link.
- Update ShellV2 title to display "{beacon} @ {host}" with a link to the host details page.
- Update `GET_SHELL` GraphQL query to fetch host details.
- Refactor `useCallbackTimer` to use `moment.duration` for precise time formatting (e.g., "1 min 20s") and lenient latency handling.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
- Update ShellV2 header to include a red BETA badge and a bug report link.
- Update ShellV2 title to display "{beacon} @ {host}" with a link to the host details page.
- Update `GET_SHELL` GraphQL query to fetch host details.
- Refactor `useCallbackTimer` to use `moment.fromNow()` for time formatting and lenient latency handling.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
2 participants
This PR improves the ShellV2 page UI by adding a BETA badge, a bug report link, and linking the host name to its details page. It also refines the beacon callback timer to display precise durations using
moment.durationand handle latency more gracefully. The changes were verified using a Playwright script mocking the necessary GraphQL queries.PR created automatically by Jules for task 14030033440768163218 started by @KCarretto