Conversation
The `build-headless.sh` script for building the WASM REPL was failing because `eldritch-agent` (and its transitive dependency `pb`) was being included unconditionally in `eldritch/Cargo.toml`. `pb` pulls in `tokio` and `tonic` with features incompatible with `wasm32-unknown-unknown` (specifically requiring `mio` which fails to compile). This commit modifies `implants/lib/eldritch/eldritch/Cargo.toml` to: 1. Make `eldritch-agent` an optional dependency. 2. Gate `eldritch-agent` behind the `stdlib` feature (via `dep:eldritch-agent`). This ensures that when building for WASM using `fake_bindings` (which disables `stdlib`), `eldritch-agent` is excluded, breaking the dependency chain to the incompatible crates. Verified by running `./build-headless.sh` which now succeeds and produces updated WASM artifacts. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
KCarretto
deleted the
fix-eldritch-wasm-build-headless-18152213475528262389
branch
1 participant
Fixes the
build-headless.shscript foreldritch-wasmby making theeldritch-agentdependency optional in theeldritchcrate. This prevents heavy system dependencies (likepb,tokio,tonic) from being pulled into the WASM build when usingfake_bindings, resolving compilation errors related tomioonwasm32-unknown-unknown.PR created automatically by Jules for task 18152213475528262389 started by @KCarretto