Enable click selection for ShellV2 autocomplete#1935
Conversation
- Refactor `useShellTerminal` hook to extract `applyCompletion` and other helpers using `useCallback`. - Expose `handleCompletionSelect` (aliased `applyCompletion`) from `useShellTerminal`. - Update `ShellCompletions` component to accept an `onCompletionSelect` prop and trigger it on `onMouseDown` (with `preventDefault` to maintain focus). - Wire up `handleCompletionSelect` through `ShellTerminal` to `ShellCompletions` in `ShellV2`. This allows users to click on an autocomplete suggestion in the terminal UI to insert it into the input buffer. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
KCarretto
deleted the
shellv2-autocomplete-click-14235572639723233517
branch
1 participant
Implemented click-to-select functionality for the shellv2 autocomplete menu. This involved refactoring the
useShellTerminalhook to expose the completion application logic and updating the UI components to handle mouse events.PR created automatically by Jules for task 14235572639723233517 started by @KCarretto