Skip to content

feat(shellv2): implement websocket reconnection logic and status indicator#1940

Merged
KCarretto merged 2 commits intomainfrom
shellv2-websocket-reconnect-4884011573793862373
Feb 27, 2026
Merged

feat(shellv2): implement websocket reconnection logic and status indicator#1940
KCarretto merged 2 commits intomainfrom
shellv2-websocket-reconnect-4884011573793862373

Conversation

@KCarretto
Copy link
Collaborator

This PR implements automatic WebSocket reconnection logic for the Shell V2 page.

Changes include:

  • HeadlessWasmAdapter now handles reconnection attempts with a backoff strategy and exposes connection status updates.
  • useShellTerminal hook consumes the connection status, updating the UI state and preventing user input when the connection is lost.
  • ShellStatusBar now features a visual indicator (icons) for the current connection status.
  • Added unit tests for ShellStatusBar to ensure correct rendering of connection states.

PR created automatically by Jules for task 4884011573793862373 started by @KCarretto

…cator

- Modified `HeadlessWasmAdapter` to support reconnection logic and expose connection status.
- Updated `useShellTerminal` hook to manage connection status state and block input when disconnected.
- Updated `ShellStatusBar` to display connection status (Connected, Disconnected, Reconnecting) with tooltips.
- Added unit tests for `ShellStatusBar` to verify rendering of different states.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2714    ±0 2714    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1358 2714 2714 0 0 0 0 492268h 8m

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2714 0 0 5.6s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.6s 5.6s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review February 27, 2026 04:18
@KCarretto KCarretto merged commit 08690ae into main Feb 27, 2026
8 checks passed
@KCarretto KCarretto deleted the shellv2-websocket-reconnect-4884011573793862373 branch February 27, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant