Skip to content

Filter reserved keywords from WASM REPL autocomplete#1948

Merged
KCarretto merged 3 commits intomainfrom
wasm-repl-filter-keywords-16967836529602966544
Feb 27, 2026
Merged

Filter reserved keywords from WASM REPL autocomplete#1948
KCarretto merged 3 commits intomainfrom
wasm-repl-filter-keywords-16967836529602966544

Conversation

@KCarretto
Copy link
Collaborator

This change modifies the Interpreter::complete method in eldritch-core/src/interpreter/core.rs to filter out reserved Python keywords from the autocomplete suggestions. Previously, keywords like def, if, True, False, etc., were explicitly added to the candidates list. This logic has been removed, and a filter has been added to exclude any keywords that might be present in the environment (e.g., pass). This results in a cleaner autocomplete experience for the WASM REPL, suggesting only relevant variables and functions. Tests in eldritch-wasm were updated to verify this behavior.


PR created automatically by Jules for task 16967836529602966544 started by @KCarretto

- Modified `Interpreter::complete` in `eldritch-core` to exclude reserved keywords (like `def`, `if`, `pass`, etc.) from completion candidates.
- This ensures that only relevant variables, functions, and builtins are suggested to the user.
- Updated `headless_test.rs` in `eldritch-wasm` to verify that keywords are filtered out.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2725    ±0 2725    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1377 2725 2725 0 0 0 0 44.1s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2725 0 0 5.6s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.6s 5.6s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.1s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review February 27, 2026 06:26
@KCarretto KCarretto merged commit 5d59482 into main Feb 27, 2026
7 of 8 checks passed
@KCarretto KCarretto deleted the wasm-repl-filter-keywords-16967836529602966544 branch February 27, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant