Filter reserved keywords from WASM REPL autocomplete#1948
Conversation
- Modified `Interpreter::complete` in `eldritch-core` to exclude reserved keywords (like `def`, `if`, `pass`, etc.) from completion candidates. - This ensures that only relevant variables, functions, and builtins are suggested to the user. - Updated `headless_test.rs` in `eldritch-wasm` to verify that keywords are filtered out. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
This change modifies the
Interpreter::completemethod ineldritch-core/src/interpreter/core.rsto filter out reserved Python keywords from the autocomplete suggestions. Previously, keywords likedef,if,True,False, etc., were explicitly added to the candidates list. This logic has been removed, and a filter has been added to exclude any keywords that might be present in the environment (e.g.,pass). This results in a cleaner autocomplete experience for the WASM REPL, suggesting only relevant variables and functions. Tests ineldritch-wasmwere updated to verify this behavior.PR created automatically by Jules for task 16967836529602966544 started by @KCarretto