Fix ShellV2 active users query validation error#1950
Conversation
The `GET_SHELL_ACTIVE_USERS` query was incorrectly requesting fields directly on `activeUsers`, which is a Relay connection type (`UserConnection`). This caused GraphQL validation errors.
This change:
1. Updates the query to request `edges { node { id name } }`.
2. Updates `useShellData` hook to flatten the connection edges back into an array of users for the component.
This fixes the "Cannot query field \"id\" on type \"UserConnection\"" error.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
KCarretto
deleted the
fix-shellv2-active-users-query-3744604748372489680
branch
1 participant
Fixes
GET_SHELL_ACTIVE_USERSquery on the ShellV2 page.The
activeUsersfield on theShelltype is a Relay connection, but the query was trying to access fields directly on it. Updated the query to traverseedges.nodeand updated theuseShellDatahook to map the results accordingly.Verified with a reproduction test case and manual verification via Playwright screenshot.
PR created automatically by Jules for task 3744604748372489680 started by @KCarretto