Skip to content

feat(shellv2): improve autocomplete and docstring tooltips#1962

Merged
KCarretto merged 2 commits intomainfrom
fix-shell-completions-6452961494475872398
Feb 28, 2026
Merged

feat(shellv2): improve autocomplete and docstring tooltips#1962
KCarretto merged 2 commits intomainfrom
fix-shell-completions-6452961494475872398

Conversation

@KCarretto
Copy link
Collaborator

This PR improves the shellv2 terminal experience by fine-tuning the autocomplete and docstring menus. It adjusts the tooltip hover delays to be uniformly 250ms, ensuring they stay open slightly longer when navigating away from them but close quickly enough not to be obtrusive. The autocomplete menu now automatically closes when typing ( or when the exact function name has been fully typed. A Ctrl+Space shortcut was also added to manually trigger the autocomplete menu, displaying a "no suggestions" indicator if no completions are found.


PR created automatically by Jules for task 6452961494475872398 started by @KCarretto

- Reduce docstring tooltip close delay from 500ms to 250ms
- Add a 250ms close delay for docstrings inside autocompletions menu
- Close autocompletions when a function is fully typed out or a parenthesis `(` is typed
- Add `Ctrl+Space` shortcut to force open the autocompletions menu, showing "no suggestions" if none are available

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2727    ±0 2727    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1429 2727 2727 0 0 0 0 43.2s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2727 0 0 6.0s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 6.0s 6.0s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
TestDockerExecutor_Build_SimpleEcho 1 3.4s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review February 28, 2026 01:36
@KCarretto KCarretto merged commit 8d3d977 into main Feb 28, 2026
8 checks passed
@KCarretto KCarretto deleted the fix-shell-completions-6452961494475872398 branch February 28, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant