Add signal() method to ProcessLibrary for sending signals to processes#2017
Merged
Add signal() method to ProcessLibrary for sending signals to processes#2017
Conversation
Implements process.signal(pid, signal) per issue #2012. On Unix (Linux, macOS, BSD), delegates directly to libc::kill() with the raw platform-native signal integer, so caller-supplied numbers map to the correct OS signal on each platform without any translation layer. On Windows, maps the common POSIX signal integers (2/SIGINT, 9/SIGKILL, 15/SIGTERM) to sysinfo Signal variants backed by TerminateProcess; other values return a descriptive error. https://claude.ai/code/session_01NnhY1itaJniUekeFZrWChT
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
…ate test to use it.
KCarretto
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
This PR adds a new
signal()method to the ProcessLibrary that allows sending signals to processes by their process ID. This enables Eldritch scripts to terminate or control processes programmatically.Key changes:
signal(pid: i64, signal: i64)method to the ProcessLibrary traitlibc::kill()with native signal numberssysinfocrate, supporting signals 2 (SIGINT), 9 (SIGKILL), and 15 (SIGTERM)The method provides a cross-platform interface for process signaling, with appropriate error handling for cases like process not found, permission denied, or unsupported signals on Windows.
Which issue(s) this PR fixes:
Fixes #2012
https://claude.ai/code/session_01NnhY1itaJniUekeFZrWChT