Skip to content

Bytes update#2019

Merged
KCarretto merged 7 commits intomainfrom
bytes-update
Mar 3, 2026
Merged

Bytes update#2019
KCarretto merged 7 commits intomainfrom
bytes-update

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Mar 3, 2026

What type of PR is this?

What this PR does / why we need it:

  • Update _binary function to use bytes
  • Add byte subscription b"\x41\x42"[0:1] -> b"AB" b"\x41\x42"[0] -> 65
  • Add write_binary

Which issue(s) this PR fixes:

Fixes #2005

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2737    ±0 2737    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1478 2737 2737 0 0 0 0 37.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2737 0 0 6.1s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 6.1s 6.1s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.8s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.8s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.8s
TestDockerExecutor_Build_SimpleEcho 1 4.1s 4.1s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto self-requested a review March 3, 2026 20:26
@KCarretto KCarretto added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 3a5e318 Mar 3, 2026
9 checks passed
@KCarretto KCarretto deleted the bytes-update branch March 3, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Update _binary functions to use bytes not vec<u8>

2 participants