Merged
Conversation
Mapped the string process statuses back to their `eldritch::process::Status` enum values in `implants/lib/eldritch/stdlib/eldritch-libreport/src/std/process_list_impl.rs` so that they get properly reported to the C2. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
- Removed `.to_string()` which wraps `Value::String` into extra quotes. - Mapped string versions of process statuses back to the enum. - Accounted for possible typo variants `Wakekill` and `UninterruptibleDiskSleep`. - Formatted properly via `cargo fmt`. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Mapped string versions of process statuses back to the enum. - Add inline tests to verify proper mapping of process status values across environments. - Formatted via cargo fmt. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Mapped string versions of process statuses back to the enum. - Add inline integration tests to verify proper mapping of process status values across environments using sysinfo process spawned. - Removed usage of `.to_string()` for string extracting inside map to fix JSON serialization quotes. - Formatted via cargo fmt. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Mapped string versions of process statuses back to the enum in `implants/lib/eldritch/stdlib/eldritch-libreport/src/std/process_list_impl.rs`. - Added inline integration test `test_process_list_status_mapping_integration` to verify process status mappings by spawning an actual process using `std::process::Command` across Windows, Mac, and Linux without relying on MockAgent logic. - Included `eldritch-libprocess` to the dev dependencies of `eldritch-libreport`. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Added `"Runnable"` state to the `map_status` arm handling the `"Run"` logic, as `sysinfo` emits `"Runnable"` dynamically on Windows and macOS. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Added a short comment explicitly noting why `Runnable` is handled along with `Run` and `Running`, for future clarity. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix process list to report process status
Mapped the string process statuses back to their
eldritch::process::Statusenum values inimplants/lib/eldritch/stdlib/eldritch-libreport/src/std/process_list_impl.rsso that they get properly reported to the C2.PR created automatically by Jules for task 12297551028211506192 started by @hulto