Fix shell portal upgrade logic and add ShellPayload output separation…#2029
Merged
Fix shell portal upgrade logic and add ShellPayload output separation…#2029
Conversation
…#2024) * fix: upgrade shell portal handling to use ShellPayload with output and error fields This commit resolves issues with portal upgrades in shellv2. It updates the polling logic in the websocket handler to use the shell's beacon edge to identify active portals. It extends the `ShellPayload` to include distinct `output` and `error` fields, migrating away from using `BytesPayload` for portal output to provide better standard stream separation. The rust implant has been updated to use these new fields. Finally, it adds a descriptive hover tooltip to the frontend to communicate portal state. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com> * fix: upgrade shell portal handling and UI indicators This commit improves the active portal handling and UI feedback in shellv2. It updates the polling logic to find the active portal via the shell's beacon edge instead of the shell edge. It introduces `output` and `error` fields to the `ShellPayload` for correct standard stream routing, mitigating the need to parse payload bytes manually. Finally, it adds a connection-aware, color-coded tooltip to the frontend shell status bar to inform the user about the active low-latency portal state. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com> --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves issues with portal upgrades in shellv2. It updates the polling logic in the websocket handler to use the shell's beacon edge to identify active portals. It extends the
ShellPayloadto include distinctoutputanderrorfields, migrating away from usingBytesPayloadfor portal output to provide better standard stream separation. The rust implant has been updated to use these new fields. Finally, it adds a descriptive hover tooltip to the frontend to communicate portal state.This commit improves the active portal handling and UI feedback in shellv2. It updates the polling logic to find the active portal via the shell's beacon edge instead of the shell edge. It introduces
outputanderrorfields to theShellPayloadfor correct standard stream routing, mitigating the need to parse payload bytes manually. Finally, it adds a connection-aware, color-coded tooltip to the frontend shell status bar to inform the user about the active low-latency portal state.