Update process list and process tree tomes to not accept an input parameter#2039
Update process list and process tree tomes to not accept an input parameter#2039
Conversation
…ters - Removed the `cmd_substring` parameter from `tavern/tomes/process_list/main.eldritch` and `tavern/tomes/process_tree/main.eldritch`. - Updated the script logic so that both tomes always return the full process list/tree. - Removed the `paramdefs` sections from the corresponding `metadata.yml` files. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
…ters
- Removed the `cmd_substring` parameter from `tavern/tomes/process_list/main.eldritch` and `tavern/tomes/process_tree/main.eldritch`.
- Updated the script logic so that both tomes always return the full process list/tree.
- Removed the `paramdefs` sections from the corresponding `metadata.yml` files.
- Fixed a KeyError when accessing 'username' by using `.get('username', 'unknown')`.
Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
1 participant
Removes the
cmd_substringparameter from theprocess_listandprocess_treetomes, updating them to always return all processes instead of filtering by a substring.PR created automatically by Jules for task 3894020006312284211 started by @hulto