Skip to content

Fix socks5_bin authentication to prioritize TAVERN_API_TOKEN#2044

Merged
hulto merged 1 commit intomainfrom
fix-socks5-auth-env-var-6168827854427937255
Mar 8, 2026
Merged

Fix socks5_bin authentication to prioritize TAVERN_API_TOKEN#2044
hulto merged 1 commit intomainfrom
fix-socks5-auth-env-var-6168827854427937255

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Mar 7, 2026

Fix socks5_bin authentication to prioritize TAVERN_API_TOKEN over RDA. This addresses the failing E2E test.


PR created automatically by Jules for task 6168827854427937255 started by @hulto

The socks5 proxy was ignoring the `TAVERN_API_TOKEN` environment variable and falling back to Remote Device Authentication (RDA). It was looking for `TAVERN_API_KEY` instead. This commit updates the `EnvAPIKey` constant in `bin/socks5/auth.go` to match the expected `TAVERN_API_TOKEN` variable name, fixing the failing E2E test.

Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2743    ±0 2743    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1554 2743 2743 0 0 0 0 38.8s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2743 0 0 5.7s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.7s 5.7s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@hulto hulto marked this pull request as ready for review March 7, 2026 05:24
@hulto hulto merged commit d816811 into main Mar 8, 2026
8 checks passed
@hulto hulto deleted the fix-socks5-auth-env-var-6168827854427937255 branch March 8, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant