Skip to content

Fix function forward references in eldritch-core#2079

Merged
KCarretto merged 4 commits intomainfrom
fix-eldritch-forward-refs-16218085057380453992
Mar 14, 2026
Merged

Fix function forward references in eldritch-core#2079
KCarretto merged 4 commits intomainfrom
fix-eldritch-forward-refs-16218085057380453992

Conversation

@KCarretto
Copy link
Collaborator

Fix NameError for forward function references by adding a pre-execution hoisting pass.

This commit fixes a bug in eldritch-core where functions failed to resolve references to other functions that were defined later in the same execution block.

By introducing a hoist_functions pre-pass, function signatures are successfully evaluated and stored in the environment before any statements are executed, permitting forward-references.

Default arguments are skipped during hoisting and correctly evaluated during the sequential evaluation pass. This maintains compatibility with dynamically evaluated parameters that rely on prior sequentially-executed statements in the same scope, and accurately resolves redefinitions.


PR created automatically by Jules for task 16218085057380453992 started by @KCarretto

…tion hoisting pass

This commit fixes a bug in `eldritch-core` where functions failed to resolve references to other functions that were defined later in the same execution block.

By introducing a `hoist_functions` pre-pass, function signatures are successfully evaluated and stored in the environment before any statements are executed, permitting forward-references.

Default arguments are skipped during hoisting and correctly evaluated during the sequential evaluation pass. This maintains compatibility with dynamically evaluated parameters that rely on prior sequentially-executed statements in the same scope, and accurately resolves redefinitions.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2816    ±0 2816    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1686 2816 2816 0 0 0 0 39.3s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2816 0 0 5.6s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.6s 5.6s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 4.9s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 4.9s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 4.9s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review March 14, 2026 19:35
@KCarretto KCarretto merged commit 5dabbf1 into main Mar 14, 2026
8 checks passed
@KCarretto KCarretto deleted the fix-eldritch-forward-refs-16218085057380453992 branch March 14, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant