Conversation
- Modify `get_reg`, `write_reg_hex`, `write_reg_int`, and `write_reg_str` in `eldritch-libsys` to take a single `path` parameter instead of separate `hive` and `path`. - Introduce `parse_registry_path` to split the combined path into a hive and subkey. - Support shortened hive aliases like `HKLM`, `HKCU`, etc. alongside the expanded versions. - Update `std` and `fake` implementations, as well as associated test files. - Update `get_registry` and `enable_rdp` tomes (`main.eldritch` and `metadata.yml`) to use the new single path argument. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Modify `get_reg` in `eldritch-libsys` to take a single `path` parameter instead of separate `hive` and `path`. - Introduce `parse_registry_path` to split the combined path into a hive and subkey. - Support shortened hive aliases like `HKLM`, `HKCU`, etc. alongside the expanded versions. - Consolidate `write_reg_hex`, `write_reg_int`, and `write_reg_str` into a single `write_reg` function. - `write_reg` accepts an `eldritch_core::Value` parameter and performs type checking depending on the provided registry type string (e.g. `REG_DWORD`, `REG_SZ`, `REG_BINARY`). - Update `std` and `fake` implementations, as well as associated test files. - Update `get_registry` and `enable_rdp` tomes (`main.eldritch` and `metadata.yml`) to use the new single path argument and `sys.write_reg`. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Replaced `write_reg_str`, `write_reg_int`, and `write_reg_hex` with a single `write_reg` function. - The new `write_reg` function accepts any `eldritch_core::Value` type and dynamically validates it against the specified registry type (e.g., matching a string to `REG_SZ`, int or parsed string to `REG_DWORD`). - Unified the path parameter for registry writes to match the newly updated `get_reg` single-path parameter. - Updated `fake.rs`, `std.rs`, and mock libraries to reflect the method signature change. - Re-wrote and migrated unit tests from the removed individual implementations to the unified `write_reg_impl.rs` file. - Updated `bindings_test.rs` to assert the new bindings signature. - Removed unused imports and cleaned up formatting. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Modify `parse_registry_path` to convert `\\` to `\` before splitting the path. - Add tests to ensure both single, double and mixed backslashes are supported in `parse_registry_path`. - Fix build and fmt issues. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Modify `parse_registry_path` to normalize `\\` to `\` before splitting the path to extract the hive. - Add tests in `reg_utils.rs` to verify correct behavior with single, double, and mixed backslash usage. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Ran `cargo fmt` to fix formatting issues in `implants/lib/eldritch/stdlib/eldritch-libsys/src/std/reg_utils.rs` and `implants/lib/eldritch/stdlib/eldritch-libsys/src/std/write_reg_impl.rs` which were causing the implants CI check runs to fail. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Update `sys.write_reg` and `sys.get_reg` documentation in `eldritch.md` to reflect the new single-path and consolidated value-agnostic variations. - Run `generate-docs.js` to update `eldritch-docs.json`. - Restored inadvertently deleted `d.ts` typescript interfaces inside `tavern/internal/www`. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Removed outdated documentation for `sys.write_reg_hex`, `sys.write_reg_int`, and `sys.write_reg_str` from `docs/_docs/user-guide/eldritch.md`. - Added updated documentation for `sys.write_reg` with examples mapping to the new signature in `docs/_docs/user-guide/eldritch.md`. - Re-generated `tavern/internal/www/src/assets/eldritch-docs.json` by running `generate-docs.js`. - Cleaned up output log file and checked frontend UI build integrity. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
- Updated `tavern/internal/portals/integration_test.go` to generate dynamic random identifiers (appending `time.Now().UnixNano()`) instead of hardcoded strings for Users, Hosts, and Beacons. - This resolves intermittent `UNIQUE constraint failed` test failures during `go test`. - Removed accidental `.patch`, `.orig`, `.rej`, and `output.log` files that were erroneously staged during investigation. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #