Skip to content

Add diffs computed field to Quest GraphQL type#2138

Merged
KCarretto merged 3 commits intomainfrom
add-quest-taskdiffs-10100399020243042076
Mar 26, 2026
Merged

Add diffs computed field to Quest GraphQL type#2138
KCarretto merged 3 commits intomainfrom
add-quest-taskdiffs-10100399020243042076

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

This PR extends the Quest GraphQL type to add a new diffs computed field.
It aggregates Tasks associated with a Quest that have the same output and error into bundles.

Example GraphQL response:

{
  "quests": [
    {
      "diffs": [
        { "ids": [1, 2, 3], "output": "A", "error": "" },
        { "ids": [4, 5, 6], "output": "B", "error": null },
        { "ids": [7, 8, 9], "output": "A", "error": "also this happened" },
        { "ids": [10, 11, 12], "output": null, "error": "I failed entirely" },
        { "ids": [13, 14, 15], "output": null, "error": null }
      ]
    }
  ]
}

New GraphQL types:

type TaskDiff {
    ids: [ID!]!
    output: String
    error: String
}

extend type Quest {
    diffs: [TaskDiff!]! @goField(forceResolver: true)
}

Testing included using the .yml test data framework. Output order is guaranteed deterministic by sorting output and error values.


PR created automatically by Jules for task 10100399020243042076 started by @KCarretto

This extends the `Quest` GraphQL type to include a computed `diffs` field
which aggregates tasks by identical `(Output, Error)` tuples. Null and empty string
values are treated equivalently and whitespace is trimmed.
Tests have been added to the GraphQL API test suite.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2841    ±0 2841    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1884 2841 2841 0 0 0 0 41.3s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2841 0 0 5.6s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.6s 5.6s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

This extends the `Quest` GraphQL type to include a computed `diffs` field
which aggregates tasks by identical `(Output, Error)` tuples. Null and empty string
values are treated equivalently and whitespace is trimmed.
Tests have been added to the GraphQL API test suite to verify grouping of
multiple tasks matching the same output and error into a single `TaskDiff`.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto KCarretto marked this pull request as ready for review March 25, 2026 04:34
… data

This extends the `Quest` GraphQL type to include a computed `diffs` field
which aggregates tasks by identical `(Output, Error)` tuples and matching
reported structured data (`FILE` and/or `PROCESS`).
Null and empty string values are treated equivalently and whitespace is trimmed.
Tests have been added to the GraphQL API test suite.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto KCarretto merged commit c881dfb into main Mar 26, 2026
8 checks passed
@KCarretto KCarretto deleted the add-quest-taskdiffs-10100399020243042076 branch March 26, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant