Add diffs computed field to Quest GraphQL type#2138
Conversation
This extends the `Quest` GraphQL type to include a computed `diffs` field which aggregates tasks by identical `(Output, Error)` tuples. Null and empty string values are treated equivalently and whitespace is trimmed. Tests have been added to the GraphQL API test suite. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This extends the `Quest` GraphQL type to include a computed `diffs` field which aggregates tasks by identical `(Output, Error)` tuples. Null and empty string values are treated equivalently and whitespace is trimmed. Tests have been added to the GraphQL API test suite to verify grouping of multiple tasks matching the same output and error into a single `TaskDiff`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
… data This extends the `Quest` GraphQL type to include a computed `diffs` field which aggregates tasks by identical `(Output, Error)` tuples and matching reported structured data (`FILE` and/or `PROCESS`). Null and empty string values are treated equivalently and whitespace is trimmed. Tests have been added to the GraphQL API test suite. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
This PR extends the
QuestGraphQL type to add a newdiffscomputed field.It aggregates Tasks associated with a Quest that have the same output and error into bundles.
Example GraphQL response:
{ "quests": [ { "diffs": [ { "ids": [1, 2, 3], "output": "A", "error": "" }, { "ids": [4, 5, 6], "output": "B", "error": null }, { "ids": [7, 8, 9], "output": "A", "error": "also this happened" }, { "ids": [10, 11, 12], "output": null, "error": "I failed entirely" }, { "ids": [13, 14, 15], "output": null, "error": null } ] } ] }New GraphQL types:
Testing included using the
.ymltest data framework. Output order is guaranteed deterministic by sortingoutputanderrorvalues.PR created automatically by Jules for task 10100399020243042076 started by @KCarretto