Conversation
The `eldritch-wasm` build was failing because it depends on `eldritch-libchain` when the `stdlib` feature is enabled. `eldritch-libchain` depends on WASM-incompatible libraries like `tokio`, `hyper`, and `tonic`. This patch introduces a `fake_bindings` feature to `eldritch-libchain` that stubs out the `tcp` method (returning an error indicating it's unsupported in the browser). The actual implementations are gated behind the `stdlib` feature, making the native dependencies optional. The `eldritch` core crate has also been updated to register the `FakeChainLibrary` when `with_fake_agent` is called, ensuring the browser REPL can compile and link correctly against the stubbed version. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
KCarretto
commented
Apr 9, 2026
|
|
||
| impl ChainLibrary for FakeChainLibrary { | ||
| fn tcp(&self, _addr: String) -> Result<i64, String> { | ||
| Err("chain is not supported in the browser repl".into()) |
Collaborator
Author
There was a problem hiding this comment.
jules, change this to say that it's just not supported in this environment
Per PR feedback, the wording was changed to specify that chain is not supported in this environment (instead of the browser REPL specifically). Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
KCarretto
deleted the
fix-eldritch-wasm-build-libchain-807419892841067013
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
wasm32-unknown-unknowncompilation failure ineldritch-wasmcaused byeldritch-libchainpulling in native-only network dependencies (tokio,hyper,tonic).PR created automatically by Jules for task 807419892841067013 started by @KCarretto