Add pnet Connection implementing net.Conn over portals#2184
Conversation
Refactors `OrderedReader` and `OrderedWriter` to support Read and Write deadlines and implements `pnet.Connection`, which fulfills the `net.Conn` interface for TCP and UDP communication over portal streams. Tests are included to verify deadlines, split reads, and proper EOF signaling upon stream closure. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Fail Rate
Failed Tests
Test Changes0 test added, 0 removed Slowest Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Implements
net.Connover portals by using the stream packet infrastructure, which allows standard net operations like Dial, Read, Write, and Deadlines over Tavern's portal connections.PR created automatically by Jules for task 8883179146587030842 started by @KCarretto