Skip to content

Add pnet Connection implementing net.Conn over portals#2184

Merged
KCarretto merged 2 commits intomainfrom
feat/pnet-connection-8883179146587030842
Apr 10, 2026
Merged

Add pnet Connection implementing net.Conn over portals#2184
KCarretto merged 2 commits intomainfrom
feat/pnet-connection-8883179146587030842

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Implements net.Conn over portals by using the stream packet infrastructure, which allows standard net operations like Dial, Read, Write, and Deadlines over Tavern's portal connections.


PR created automatically by Jules for task 8883179146587030842 started by @KCarretto

Refactors `OrderedReader` and `OrderedWriter` to support Read and Write deadlines and implements `pnet.Connection`, which fulfills the `net.Conn` interface for TCP and UDP communication over portal streams. Tests are included to verify deadlines, split reads, and proper EOF signaling upon stream closure.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2941 2940 1 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1967 2941 2940 1 0 0 0 493272h 55m

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2941 0 1 7m 8s

Fail Rate

Fail Rate 0.03%
Test 📝 Results 📊 Passed ✅ Failed ❌ Fail Rate (%) 📈
TestMetrics_QuestTimelineChart 1 0 1 100.00    ↑100.00

Failed Tests

Failed Tests
❌ TestMetrics_QuestTimelineChart
=== RUN   TestMetrics_QuestTimelineChart
    metrics_test.go:101: 
        	Error Trace:	/home/runner/work/realm/realm/tavern/internal/graphql/metrics_test.go:101
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestMetrics_QuestTimelineChart
--- FAIL: TestMetrics_QuestTimelineChart (0.02s)

Trace:

No trace available

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 31s 7m 8s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 31s 7m 8s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 31s 7m 8s
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto marked this pull request as ready for review April 10, 2026 00:57
@KCarretto KCarretto merged commit 5879019 into main Apr 10, 2026
8 checks passed
@KCarretto KCarretto deleted the feat/pnet-connection-8883179146587030842 branch April 10, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant