feat(eldritch): add dns library with list_a_records#2191
Merged
Conversation
Contributor
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Collaborator
Author
|
Adding details for binary size comparison: main debug linux: 325.17 MB main release linux: 8.84 MB results: 0.53% debug binary size increase |
KCarretto
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a brand new module into the Eldritch Standard Library:
eldritch-libdns. The library enables DNS lookups within Eldritch scripts.Changes Made
DnsLibrarytrait under newly createdeldritch-libdnsRust crate package.list_a_records(domain, nameserver)function exposing A-record lookup capabilities.DnsLibraryFake) for internal tests, WebAssembly UI target (eldritch-wasm), and Repl mock modes.StdDnsLibrary) heavily leveraging thehickory-resolvercrate dependency to perform true network lookups (optionally accepting a custom DNS nameserver parameter).eldritch-libdnsappropriately intoeldritch/Cargo.tomlas a primary workspace-level standard library.Verification
cargo test -p eldritch).