feat(eldritch): refactor dns to list and add CNAME support#2193
Merged
feat(eldritch): refactor dns to list and add CNAME support#2193
Conversation
Contributor
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
dnslibrary and add CNAME supportOverview
This PR refactors our newly introduced
dns.list_a_recordsfunction to be more generic and extensible. The core method has been renamed todns.listand now accepts an optionalrecord_typeparameter (capable of resolving"A"and"CNAME"records natively). To ensure code quality and testability, resolution logic within thestdbindings has been separated into dedicated internal helper methods.Key Changes
dns.list_a_recordswithdns.list(domain, record_type='A', nameserver=None), enabling multi-type DNS probing.CNAMErecords by invokingdns.list("domain.com", record_type="CNAME"). Defaults safely to IPv4 (A) if unspecified.resolve_a_records()andresolve_cname_records()functions withinstd/mod.rsfor readability and maintainability.DnsLibraryFaketo appropriately handle assertions over both record types to guarantee mock-test coverage without breakingcargo check/WASM builds.docs/_docs/user-guide/eldritch.mdto reflectdns.listalong with functional snippet examples capturing the default and keyword invocation structures.Testing
cargo test -p eldritchsucceedscargo check -p eldritch-libdnsAandCNAMEreturn values infake/stdlogic paths.