Skip to content

Add Event Ent Schema and Fix Flaky Tests#2194

Merged
KCarretto merged 1 commit intomainfrom
jules-6560422549513661048-2b434c4a
Apr 12, 2026
Merged

Add Event Ent Schema and Fix Flaky Tests#2194
KCarretto merged 1 commit intomainfrom
jules-6560422549513661048-2b434c4a

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

This change introduces a new Event entity in the Tavern backend schema to track events associated with hosts, beacons, and quests. The event schema uses the existing history mixins and is wired appropriately for GraphQL and code generation. Also fixed a flaky test issue introduced by tacticCounts maps not being properly sorted prior to slice iteration during timeline chart aggregations.


PR created automatically by Jules for task 6560422549513661048 started by @KCarretto

Added a new `Event` ent schema with a timestamp, kind enum, and edges connecting to `beacon`, `host`, and `quest`.
Updated the `beacon`, `host`, and `quest` ent schemas to map the inverse edge to `events`.
Regenerated `ent` and `graphql` code.
Fixed a flaky GraphQL test related to non-deterministic tactic sorting in metrics resolvers.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2780 2778 2 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1992 2780 2778 2 0 0 0 493315h 58m

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2780 0 2 15m 36s

Fail Rate

Fail Rate 0.07%
Test 📝 Results 📊 Passed ✅ Failed ❌ Fail Rate (%) 📈
TestMetrics_QuestTimelineChart 1 0 1 100.00    ↑100.00
guardrails: process::tests::test_process_guardrail 3 2 1 33.33    ↑33.33
guardrails: process::tests::test_process_guardrail 3 2 1 33.33    ↑33.33
guardrails: process::tests::test_process_guardrail 3 2 1 33.33    ↑33.33

Failed Tests

Failed Tests
❌ TestMetrics_QuestTimelineChart
=== RUN   TestMetrics_QuestTimelineChart
    metrics_test.go:101: 
        	Error Trace:	/home/runner/work/realm/realm/tavern/internal/graphql/metrics_test.go:101
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestMetrics_QuestTimelineChart
--- FAIL: TestMetrics_QuestTimelineChart (0.02s)

Trace:

No trace available
❌ guardrails: process::tests::test_process_guardrail
thread 'process::tests::test_process_guardrail' (15785) panicked at lib/guardrails/src/process.rs:68:9

Trace:

thread 'process::tests::test_process_guardrail' (15785) panicked at lib/guardrails/src/process.rs:68:9:
assertion failed: guardrail.check()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 7m 41s 15m 36s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 7m 41s 15m 36s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 7m 41s 15m 36s
TestDockerExecutor_Build_ContextCancellation 1 5.9s 5.9s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 3.9s 3.9s
imix::bin/imix: tests::task_tests::test_task_streaming_error 2 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_error 2 3.0s 3.1s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review April 12, 2026 13:47
@KCarretto KCarretto merged commit 33c8e42 into main Apr 12, 2026
6 of 8 checks passed
@KCarretto KCarretto deleted the jules-6560422549513661048-2b434c4a branch April 12, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant