Fix questTimeline metrics bucket calculation#2211
Conversation
Calculate bucket indices using time.Duration arithmetic instead of subtracting Unix timestamps. This preserves sub-second precision and ensures consistent bucket assignment, fixing flaky tests where quests created slightly after a second boundary would land in the wrong bucket. This also applies the same fix to BeaconTimelineChart. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
KCarretto
deleted the
fix-quest-timeline-metrics-test-7743241014049078338
branch
1 participant
Fixed the precision loss in quest and beacon timeline metrics by switching from Unix timestamp subtraction to Go's time.Duration arithmetic for bucket index calculation. This ensures that sub-second differences are correctly accounted for, preventing records from landing in incorrect buckets and fixing flaky tests.
PR created automatically by Jules for task 7743241014049078338 started by @KCarretto