Update notifications to link to relevant pages#2212
Conversation
- Modified `NotificationBell` to wrap notification items in `Link` components. - Added `getNotificationLink` helper to determine target URLs based on event kind. - Updated `GET_NOTIFICATIONS` query to fetch `host.id` for beacons to support `BEACON_LOST` links. - Host-related events link to `/hosts/<hostId>`. - Quest-related events link to `/tasks/<questId>`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Updated the notification system in the Tavern frontend to allow users to click on notifications and be redirected to the relevant host or quest detail page.
Key changes:
NotificationBell.tsx: Added logic to generate links forHOST_ACCESS_NEW,HOST_ACCESS_RECOVERED,HOST_ACCESS_LOST,BEACON_LOST, andQUEST_COMPLETEDevents.notifications.ts: Expanded the GraphQL query to include necessary ID fields for link construction.PR created automatically by Jules for task 5782265726811620341 started by @KCarretto