Skip to content

Allow connecting to terminated shells#2213

Merged
KCarretto merged 2 commits intomainfrom
feature/allow-terminated-shell-connection-5196400607466078584
Apr 14, 2026
Merged

Allow connecting to terminated shells#2213
KCarretto merged 2 commits intomainfrom
feature/allow-terminated-shell-connection-5196400607466078584

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

This change allows users to view the output history of terminated shell sessions.

The 'Open Shell' button in the host's shells table is now always available, even for shells marked as terminated or belonging to offline beacons.

In the shell view, if the session is terminated:

  • Keyboard and paste input is disabled.
  • The terminal text is dimmed.
  • The status bar prominently displays a "TERMINATED" badge with a tooltip showing the closure time.

Frontend unit tests have been updated and verified to pass.


PR created automatically by Jules for task 5196400607466078584 started by @KCarretto

- Update ShellsTable to show terminal button for terminated shells
- Update useShellTerminal hook to support loading terminated shells while blocking input
- Update ShellStatusBar to display a "Terminated" status when appropriate
- Fix a variable declaration order issue in useShellTerminal

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@KCarretto KCarretto marked this pull request as ready for review April 13, 2026 23:48
@KCarretto KCarretto merged commit 201af66 into main Apr 14, 2026
8 checks passed
@KCarretto KCarretto deleted the feature/allow-terminated-shell-connection-5196400607466078584 branch April 14, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant