Skip to content

Add notification bell to mobile sidebar#2218

Merged
KCarretto merged 2 commits intomainfrom
mobile-notification-bell-3003822603770566693
Apr 14, 2026
Merged

Add notification bell to mobile sidebar#2218
KCarretto merged 2 commits intomainfrom
mobile-notification-bell-3003822603770566693

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

The notification bell was missing from the mobile sidebar. This PR adds the NotificationBell component to MobileNav.tsx, placing it in the sidebar footer alongside the user profile link, matching the layout used in the desktop FullSidebarNav component.


PR created automatically by Jules for task 3003822603770566693 started by @KCarretto

This change adds the NotificationBell component to the mobile navigation
sidebar (MobileNav), ensuring consistency with the desktop sidebar.
The bell is positioned next to the user profile link in the sidebar footer
using an HStack for proper alignment.

Testing:
- Verified that the component is correctly imported and rendered in MobileNav.tsx.
- Ran frontend unit tests in tavern/internal/www; all tests passed.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2946 2946 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#2064 2946 2946 0 0 0 0 1m 6s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2946 0 0 7m 16s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 36s 7m 16s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 36s 7m 16s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 36s 7m 16s
TestDockerExecutor_Build_ContextCancellation 1 6.2s 6.2s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 3.8s 3.8s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.1s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review April 14, 2026 22:16
@KCarretto KCarretto merged commit 63ac955 into main Apr 14, 2026
8 checks passed
@KCarretto KCarretto deleted the mobile-notification-bell-3003822603770566693 branch April 14, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant