Skip to content

Adjust Process Table Padding and Column Widths#2222

Merged
KCarretto merged 3 commits intomainfrom
adjust-process-table-padding-13575400840754735500
Apr 15, 2026
Merged

Adjust Process Table Padding and Column Widths#2222
KCarretto merged 3 commits intomainfrom
adjust-process-table-padding-13575400840754735500

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

I have adjusted the process table to provide more space for the process name (the CMD column) as requested.

Key changes:

  1. VirtualizedTable Enhancement: I modified the base VirtualizedTable and its row component to accept optional paddingX and gap props. This allows specific tables to opt-in to tighter layouts while maintaining the existing defaults (px-6, gap-4) for other tables.
  2. Process Table Optimization:
    • Reduced the table's horizontal padding to px-4 and column gaps to gap-2.
    • Significantly increased the width of the CMD column (from 2fr to 4fr and min-width to 200px).
    • Reduced the width of the User (principal) column and other columns like PID, PPID, Status, and timestamps to free up horizontal space.
  3. Verification: I ran the frontend unit tests, and all 209 tests passed. I also ran go generate ./... as required by the development guidelines, which updated some generated artifacts.

PR created automatically by Jules for task 13575400840754735500 started by @KCarretto

- Add `paddingX` and `gap` props to `VirtualizedTable` for layout flexibility.
- Update `ProcessesTable` to use reduced padding (`px-4`) and gap (`gap-2`).
- Recalibrate column widths in `ProcessesTable` to prioritize the process name (CMD column).
- Shrink the 'User' (principal) column and other auxiliary columns.
- Include regenerated artifacts from `go generate`.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2949 2949 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#2078 2949 2949 0 0 0 0 1m

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2949 0 0 5m

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 3m 19s 5m
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 3m 19s 5m
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 3m 19s 5m
TestDockerExecutor_Build_ContextCancellation 1 5.6s 5.6s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Optimized the process table to prioritize the 'CMD' column by significantly
increasing its width and flex-growth while reducing the size of auxiliary
columns like 'User', 'PID', and 'Status'.

Additionally, tightened the overall layout of the `VirtualizedTable` base
component by hardcoding horizontal padding to `px-4` and column gaps to
`gap-2`, removing previous configurability to ensure a consistent, space-efficient
look across all tables in the application.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@KCarretto KCarretto marked this pull request as ready for review April 15, 2026 02:27
@KCarretto KCarretto merged commit 7a0cf2c into main Apr 15, 2026
8 checks passed
@KCarretto KCarretto deleted the adjust-process-table-padding-13575400840754735500 branch April 15, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant