Adjust Process Table Padding and Column Widths#2222
Conversation
- Add `paddingX` and `gap` props to `VirtualizedTable` for layout flexibility. - Update `ProcessesTable` to use reduced padding (`px-4`) and gap (`gap-2`). - Recalibrate column widths in `ProcessesTable` to prioritize the process name (CMD column). - Shrink the 'User' (principal) column and other auxiliary columns. - Include regenerated artifacts from `go generate`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Optimized the process table to prioritize the 'CMD' column by significantly increasing its width and flex-growth while reducing the size of auxiliary columns like 'User', 'PID', and 'Status'. Additionally, tightened the overall layout of the `VirtualizedTable` base component by hardcoding horizontal padding to `px-4` and column gaps to `gap-2`, removing previous configurability to ensure a consistent, space-efficient look across all tables in the application. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
I have adjusted the process table to provide more space for the process name (the CMD column) as requested.
Key changes:
VirtualizedTableand its row component to accept optionalpaddingXandgapprops. This allows specific tables to opt-in to tighter layouts while maintaining the existing defaults (px-6,gap-4) for other tables.px-4and column gaps togap-2.CMDcolumn (from2frto4frandmin-widthto200px).User(principal) column and other columns likePID,PPID,Status, and timestamps to free up horizontal space.go generate ./...as required by the development guidelines, which updated some generated artifacts.PR created automatically by Jules for task 13575400840754735500 started by @KCarretto