Use host ID for filtering in quest flow#2223
Conversation
Updated the quest creation and beacon selection logic to use the host ID instead of the host name for filtering, while maintaining the display of the host name in the UI. This prevents issues when multiple hosts have the same name. Changes: - Update `getBeaconFilterNameByTypes` to extract host IDs. - Update GraphQL query construction to use `idIn` for host filters. - Update unit tests to match new behavior. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
The bug in the quest creation flow was that it used host names for filtering beacons, which could lead to incorrect results if multiple hosts shared the same name. I updated the filtering logic to use host IDs (passed via the
valueproperty of filter options) and changed the GraphQL queries to use theidInpredicate for hosts. The display remains unchanged as it uses thelabelproperty (host name). I also updated and verified the frontend unit tests.PR created automatically by Jules for task 12894318255077647548 started by @KCarretto