Skip to content

Use host ID for filtering in quest flow#2223

Merged
KCarretto merged 2 commits intomainfrom
fix-host-id-quest-flow-12894318255077647548
Apr 15, 2026
Merged

Use host ID for filtering in quest flow#2223
KCarretto merged 2 commits intomainfrom
fix-host-id-quest-flow-12894318255077647548

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

The bug in the quest creation flow was that it used host names for filtering beacons, which could lead to incorrect results if multiple hosts shared the same name. I updated the filtering logic to use host IDs (passed via the value property of filter options) and changed the GraphQL queries to use the idIn predicate for hosts. The display remains unchanged as it uses the label property (host name). I also updated and verified the frontend unit tests.


PR created automatically by Jules for task 12894318255077647548 started by @KCarretto

Updated the quest creation and beacon selection logic to use the host ID
instead of the host name for filtering, while maintaining the display of
the host name in the UI. This prevents issues when multiple hosts have
the same name.

Changes:
- Update `getBeaconFilterNameByTypes` to extract host IDs.
- Update GraphQL query construction to use `idIn` for host filters.
- Update unit tests to match new behavior.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2946 2946 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#2073 2946 2946 0 0 0 0 53.5s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2946 0 0 5m 42s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 2s 5m 42s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 2s 5m 42s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 4m 2s 5m 42s
TestDockerExecutor_Build_ContextCancellation 1 12.3s 12.3s
TestDockerExecutor_Build_SimpleEcho 1 12.2s 12.2s
TestCreateTestData 1 6.9s 6.9s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_NonZeroExit 1 4.7s 4.7s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review April 15, 2026 22:38
@KCarretto KCarretto merged commit cc9853a into main Apr 15, 2026
7 of 8 checks passed
@KCarretto KCarretto deleted the fix-host-id-quest-flow-12894318255077647548 branch April 15, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant