Skip to content

Update cat tome to support wildcard paths#2227

Merged
hulto merged 9 commits intomainfrom
copilot/update-cat-tome-support-wildcard
Apr 15, 2026
Merged

Update cat tome to support wildcard paths#2227
hulto merged 9 commits intomainfrom
copilot/update-cat-tome-support-wildcard

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

Summary

  • update the cat tome to read paths directly via file.read(path)
  • remove the file.is_file(path) guard so wildcard (*) paths are supported
  • rely on file.read() error behavior to fail fast on invalid paths

Validation

  • go test ./...
  • go test ./tavern/tomes
  • cargo test ❌ (pre-existing environment issue: IMIX_SERVER_PUBKEY not defined at compile time)
  • parallel_validation ✅ (1 non-blocking UX suggestion; no security findings)

Copilot AI requested a review from hulto April 15, 2026 01:43
@hulto hulto marked this pull request as ready for review April 15, 2026 01:44
@hulto
Copy link
Copy Markdown
Collaborator

hulto commented Apr 15, 2026

@copilot fix failing test

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 15, 2026

@copilot fix failing test

Fixed in commit 2ee47d7. I updated the cat tome to keep wildcard support while avoiding failures on non-wildcard directory paths, and re-ran the failing tome test suite successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2949 2949 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#2097 2949 2949 0 0 0 0 1m 1s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2949 0 0 3m 55s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 3m 2s 3m 55s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 3m 2s 3m 55s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 3m 2s 3m 55s
TestDockerExecutor_Build_ContextCancellation 1 5.7s 5.7s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 3.3s 3.3s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@hulto hulto merged commit 8444e6b into main Apr 15, 2026
8 checks passed
@hulto hulto deleted the copilot/update-cat-tome-support-wildcard branch April 15, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants