Skip to content

[AI] Make HostProcess principal field optional#2231

Merged
KCarretto merged 2 commits intomainfrom
fix-host-process-principal-optional-12980144447402907872
Apr 15, 2026
Merged

[AI] Make HostProcess principal field optional#2231
KCarretto merged 2 commits intomainfrom
fix-host-process-principal-optional-12980144447402907872

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Updated the HostProcess ent schema in tavern/internal/ent/schema/host_process.go to make the principal field optional and removed the .NotEmpty() validator. This change satisfies the requirement for issue #1758.

Key changes:

  • Modified tavern/internal/ent/schema/host_process.go.
  • Regenerated Ent and GraphQL code using go generate ./tavern/internal/ent.
  • Verified that principal is now nillable and optional in the generated builders.
  • Ran backend integration and unit tests (ent, c2, graphql) to ensure no regressions.

PR created automatically by Jules for task 12980144447402907872 started by @KCarretto

Update the HostProcess entity schema to mark the 'principal' field as optional
and remove its 'NotEmpty' validator. This change allows reporting processes
without a known principal.

Regenerated Ent and GraphQL artifacts to reflect the schema change.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2949 2949 0 0 0 0 1ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#2099 2949 2949 0 0 0 0 1m

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2949 0 0 3m 28s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 2m 32s 3m 28s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 2m 32s 3m 28s
eldritch-libfile: std::list_recent_impl::tests::test_list_recent_default_args 3 2m 32s 3m 28s
TestDockerExecutor_Build_ContextCancellation 1 5.7s 5.7s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 3.3s 3.3s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review April 15, 2026 22:39
@KCarretto KCarretto merged commit d0ea885 into main Apr 15, 2026
8 checks passed
@KCarretto KCarretto deleted the fix-host-process-principal-optional-12980144447402907872 branch April 15, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant