[AI] Mark notifications as read on popover close#2235
Conversation
This change modifies the `NotificationBell` component to trigger the `markNotificationsAsRead` mutation when the popover is closed, instead of when it is opened or when tabs are switched. This ensures that notifications are only marked as read after the user has had an opportunity to view them. - Added `handleClose` function to call `markAsRead` for all unread items. - Registered `handleClose` with `Popover.onClose`. - Removed redundant `onOpen` logic from `Popover`. - Removed `handleTabChange` and its usage in `Tabs.onChange`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
Update our notifications to markAsRead when the notification popover is closed.
PR created automatically by Jules for task 14777187924910490976 started by @KCarretto